CID 313104: Error handling issues in lib/ns/query.c
@dfronza This seem to come from 8cc5abff and it slipped to %November 2020 (9.11.25, 9.11.25-S1, 9.16.9, 9.16.9-S1, 9.17.7) release, please address it in %December 2020 (9.11.26, 9.11.26-S1, 9.16.10, 9.16.10-S1, 9.17.8):
*** CID 313104: Error handling issues (CHECKED_RETURN)
/lib/ns/query.c: 5582 in query_lookup()
5576 {
5577 dboptions |= DNS_DBFIND_COVERINGNSEC;
5578 }
5579
5580 dns_db_getservestalerefresh(qctx->client->view->cachedb,
5581 &stale_refresh);
>>> CID 313104: Error handling issues (CHECKED_RETURN)
>>> Calling "dns_db_getservestalettl" without checking return value (as is done elsewhere 4 out of 5 times).
5582 dns_db_getservestalettl(qctx->client->view->cachedb, &stale_ttl);
5583 if (stale_refresh > 0) {
5584 if (qctx->client->view->staleanswersok == dns_stale_answer_yes)
5585 {
5586 dboptions |= DNS_DBFIND_STALEENABLED;
5587 } else if (qctx->client->view->staleanswersok ==
Edited by Michal Nowak