Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Planning hierarchy
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 527
    • Issues 527
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 101
    • Merge requests 101
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source Projects
  • BINDBIND
  • Issues
  • #2468

Closed
Open
Created Feb 03, 2021 by Mark Andrews@markaOwner

CID 318094: Null pointer dereferences (REVERSE_INULL)

Remove redundant version == NULL check. This should have been included in 3b11bacb.

*** CID 318094:  Null pointer dereferences  (REVERSE_INULL)
/lib/dns/rbtdb.c: 1389 in newversion()
1383     	version->xfrsize = rbtdb->current_version->xfrsize;
1384     	RWUNLOCK(&rbtdb->current_version->rwlock, isc_rwlocktype_read);
1385     	rbtdb->next_serial++;
1386     	rbtdb->future_version = version;
1387     	RBTDB_UNLOCK(&rbtdb->lock, isc_rwlocktype_write);
1388     
   CID 318094:  Null pointer dereferences  (REVERSE_INULL)
   Null-checking "version" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
1389     	if (version == NULL) {
1390     		return (result);
1391     	}
1392     
1393     	*versionp = version;
1394
Edited Feb 03, 2021 by Mark Andrews
Assignee
Assign to
Time tracking