Review of 9.11 subscription ECS support
ecs-review-of-v9_11
branch on the isc-private/bind9
repo has various changes that need to be reviewed.
Some other points that need further consideration:
- In
lib/dns/resolver.c
,process_opt()
does not handle failure results fromprocess_ecs()
, which it must not silently ignore. - In
dns_resolver_createfetch4()
, why is duplicate checking suppressed for TCP on this branch? Why specifically for ECS (if it applies, doesn't it apply equally tomaster
as well)? - A comprehensive check of the ECS code in
v9_11_sub
vs.v9_10_sub
should be done. I've not managed to review all of it in this timeframe.