CID 373821 & CID 373822: Control flow issues in lib/dns/zone.c
Coverity Scan claims dead code in lib/dns/zone.c
on main
.
*** CID 373822: Control flow issues (DEADCODE)
/lib/dns/zone.c: 12258 in zone_dump()
12252 DNS_ZONE_CLRFLAG(zone, DNS_ZONEFLG_DUMPING);
12253 if (result != ISC_R_SUCCESS) {
12254 /*
12255 * Try again in a short while.
12256 */
12257 zone_needdump(zone, DNS_DUMP_DELAY);
>>> CID 373822: Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "if ((({
__auto_type __ato...".
12258 } else if (DNS_ZONE_FLAG(zone, DNS_ZONEFLG_FLUSH) &&
12259 DNS_ZONE_FLAG(zone, DNS_ZONEFLG_NEEDDUMP) &&
12260 DNS_ZONE_FLAG(zone, DNS_ZONEFLG_LOADED))
12261 {
12262 DNS_ZONE_CLRFLAG(zone, DNS_ZONEFLG_NEEDDUMP);
12263 DNS_ZONE_SETFLAG(zone, DNS_ZONEFLG_DUMPING);
*** CID 373821: Control flow issues (DEADCODE)
/lib/dns/zone.c: 12271 in zone_dump()
12265 again = true;
12266 } else {
12267 DNS_ZONE_CLRFLAG(zone, DNS_ZONEFLG_FLUSH);
12268 }
12269 UNLOCK_ZONE(zone);
12270 if (again) {
>>> CID 373821: Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "goto redo;".
12271 goto redo;
12272 }
12273
12274 return (result);
12275 }
12276