trust anchor telemetry log should include client IP address
Trust anchor telemetry log contains IP address of the destination (server IP address). To comply with the log message trust-anchor-telemetry '%s/%s' from %s%s
, it should be the client IP address.
Here is a patch for v9_11_4 branch:
--- bind9-v9_11_4.orig/bin/named/query.c 2018-07-03 15:56:55.000000000 +0900
+++ bind9-v9_11_4/bin/named/query.c 2018-07-04 00:12:35.667175239 +0900
@@ -9233,7 +9233,7 @@
static inline void
log_tat(ns_client_t *client) {
char namebuf[DNS_NAME_FORMATSIZE];
- char clientbuf[ISC_NETADDR_FORMATSIZE];
+ char clientbuf[ISC_SOCKADDR_FORMATSIZE];
char classname[DNS_RDATACLASS_FORMATSIZE];
isc_netaddr_t netaddr;
char *tags = NULL;
@@ -9253,7 +9253,7 @@
isc_netaddr_fromsockaddr(&netaddr, &client->peeraddr);
dns_name_format(client->query.qname, namebuf, sizeof(namebuf));
- isc_netaddr_format(&client->destaddr, clientbuf, sizeof(clientbuf));
+ isc_sockaddr_format(&client->peeraddr, clientbuf, sizeof(clientbuf));
dns_rdataclass_format(client->view->rdclass, classname,
sizeof(classname));
Also, there are some misspells trust-anchor-telementry
. For example, see bin/named/log.c#L42. I'm not sure whether these can be corrected without user impact or not.