Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 570
    • Issues 570
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 100
    • Merge requests 100
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • BINDBIND
  • Issues
  • #379
Closed
Open
Issue created Jul 03, 2018 by Ghost User@ghost

trust anchor telemetry log should include client IP address

Trust anchor telemetry log contains IP address of the destination (server IP address). To comply with the log message trust-anchor-telemetry '%s/%s' from %s%s, it should be the client IP address.

Here is a patch for v9_11_4 branch:

--- bind9-v9_11_4.orig/bin/named/query.c	2018-07-03 15:56:55.000000000 +0900
+++ bind9-v9_11_4/bin/named/query.c	2018-07-04 00:12:35.667175239 +0900
@@ -9233,7 +9233,7 @@
 static inline void
 log_tat(ns_client_t *client) {
 	char namebuf[DNS_NAME_FORMATSIZE];
-	char clientbuf[ISC_NETADDR_FORMATSIZE];
+	char clientbuf[ISC_SOCKADDR_FORMATSIZE];
 	char classname[DNS_RDATACLASS_FORMATSIZE];
 	isc_netaddr_t netaddr;
 	char *tags = NULL;
@@ -9253,7 +9253,7 @@
 
 	isc_netaddr_fromsockaddr(&netaddr, &client->peeraddr);
 	dns_name_format(client->query.qname, namebuf, sizeof(namebuf));
-	isc_netaddr_format(&client->destaddr, clientbuf, sizeof(clientbuf));
+	isc_sockaddr_format(&client->peeraddr, clientbuf, sizeof(clientbuf));
 	dns_rdataclass_format(client->view->rdclass, classname,
 			      sizeof(classname));

Also, there are some misspells trust-anchor-telementry. For example, see bin/named/log.c#L42. I'm not sure whether these can be corrected without user impact or not.

Assignee
Assign to
Time tracking