CID 451206 & CID 451208: Control flow issues in lib/dns/dst_api.c
Coverity Scan claims two new instances of dead code in lib/dns/dst_api.c
after 263d232c.
*** CID 451208: Control flow issues (DEADCODE)
/lib/dns/dst_api.c: 2258 in write_public_key()
2252 return (dst_key_cleanup(tmpname, fp));
2253 }
2254
2255 fputc('\n', fp);
2256
2257 if (ret != ISC_R_SUCCESS) {
>>> CID 451208: Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "return dst_key_cleanup(tmpn...".
2258 return (dst_key_cleanup(tmpname, fp));
2259 }
2260
2261 return (dst_key_close(tmpname, fp, filename));
2262 }
2263
*** CID 451206: Control flow issues (DEADCODE)
/lib/dns/dst_api.c: 2133 in write_key_state()
2127 printstate(key, DST_KEY_KRRSIG, "KRRSIGState", fp);
2128 printstate(key, DST_KEY_DS, "DSState", fp);
2129 printstate(key, DST_KEY_GOAL, "GoalState", fp);
2130 }
2131
2132 if (result != ISC_R_SUCCESS) {
>>> CID 451206: Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "return dst_key_cleanup(tmpn...".
2133 return (dst_key_cleanup(tmpname, fp));
2134 }
2135
2136 return (dst_key_close(tmpname, fp, filename));
2137 }
2138