CID 454693: A value assigned to addrinfo variable is never used in copy_namehook_lists()
/lib/dns/adb.c: 2229 in copy_namehook_lists()
2223
2224 /*
2225 * Found a valid entry. Add it to the find's list.
2226 */
2227 inc_entry_refcnt(adb, entry, false);
2228 ISC_LIST_APPEND(find->list, addrinfo, publink);
>>> CID 454693: (UNUSED_VALUE)
>>> Assigning value "NULL" to "addrinfo" here, but that stored value is overwritten before it can be used.
2229 addrinfo = NULL;
2230 nextv4:
2231 UNLOCK(&adb->entrylocks[bucket]);
2232 bucket = DNS_ADB_INVALIDBUCKET;
2233 namehook = ISC_LIST_NEXT(namehook, plink);
2234 }
/lib/dns/adb.c: 2264 in copy_namehook_lists()
2258
2259 /*
2260 * Found a valid entry. Add it to the find's list.
2261 */
2262 inc_entry_refcnt(adb, entry, false);
2263 ISC_LIST_APPEND(find->list, addrinfo, publink);
>>> CID 454693: (UNUSED_VALUE)
>>> Assigning value "NULL" to "addrinfo" here, but that stored value is overwritten before it can be used.
2264 addrinfo = NULL;
2265 nextv6:
2266 UNLOCK(&adb->entrylocks[bucket]);
2267 bucket = DNS_ADB_INVALIDBUCKET;
2268 namehook = ISC_LIST_NEXT(namehook, plink);
2269 }
This was identified by the new Coverity Scan 2022.12 version, so probably not a new issue, on v9.16 and v9.18.