CID 465861: Null pointer dereferences (REVERSE_INULL) /lib/ns/client.c: 2370 in ns__client_setup()
Not sure why this was triggered now. The f5af9818 commit has touched this function recently, but the detected "issue" was present there before that, IIUC.
FTR, there is nothing serious - it's just an unnecessary NULL-check.
*** CID 465861: Null pointer dereferences (REVERSE_INULL)
/lib/ns/client.c: 2370 in ns__client_setup()
2364 }
2365
2366 if (client->message != NULL) {
2367 dns_message_detach(&client->message);
2368 }
2369
>>> CID 465861: Null pointer dereferences (REVERSE_INULL)
>>> Null-checking "client->manager" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
2370 if (client->manager != NULL) {
2371 ns_clientmgr_detach(&client->manager);
2372 }
2373
2374 return (result);
2375 }