Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 589
    • Issues 589
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 95
    • Merge requests 95
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • BINDBIND
  • Merge requests
  • !10

Refactor dns__zone_updatesigs()

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Michał Kępień requested to merge refactor-update-sigs into master Dec 07, 2017
  • Overview 27
  • Commits 5
  • Pipelines 6
  • Changes 3

The do-while loop in dns__zone_updatesigs(), while short, is hard to follow due to nesting, variable reuse and tricky list traversal. This MR attempts to improve code readability by splitting that loop into a set of short, commented functions (which the compiler should be smart enough to inline anyway, as confirmed with GCC 7.2.0 on x86-64).

Edited May 10, 2018 by Michał Kępień
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: refactor-update-sigs