Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 569
    • Issues 569
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 99
    • Merge requests 99
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • BINDBIND
  • Merge requests
  • !1640

Stabilize "delzsk.example" zone checks

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Michał Kępień requested to merge 928-stabilize-delzsk.example-zone-checks into master Mar 08, 2019
  • Overview 3
  • Commits 1
  • Pipelines 3
  • Changes 1

When a zone is converted from NSEC to NSEC3, the private record at zone apex indicating that NSEC3 chain creation is in progress may be removed during a different (later) zone_nsec3chain() call than the one which adds the NSEC3PARAM record. The "delzsk.example" zone check only waits for the NSEC3PARAM record to start appearing in dig output while private records at zone apex directly affect "rndc signing -list" output. This may trigger false positives for the "autosign" system test as the output of the "rndc signing -list" command used for checking ZSK deletion progress may contain extra lines which are not accounted for. Ensure the private record is removed from zone apex before triggering ZSK deletion in the aforementioned check.

Also future-proof the ZSK deletion progress check by making it only look at lines it should care about.

See #928

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 928-stabilize-delzsk.example-zone-checks