Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
BIND
BIND
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 627
    • Issues 627
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 116
    • Merge Requests 116
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source Projects
  • BINDBIND
  • Merge Requests
  • !1641

Merged
Created Mar 08, 2019 by Michał Kępień@michalMaintainer

Fix regex used for mangling druz/DNSKEY (in the "dlv" system test)

  • Overview 3
  • Commits 1
  • Pipelines 2
  • Changes 1

During "dlv" system test setup, the "sed" regex used for mangling the DNSKEY RRset for the "druz" zone does not include the plus sign ("+"), which may:

  • cause the replacement to happen near the end of DNSKEY RDATA, which can cause the latter to become an invalid Base64 string,

  • prevent the replacement from being performed altogether.

Both cases prevent the "dlv" system test from behaving as intended and may trigger false positives. Add the missing character to the aforementioned regex to ensure the replacement is always performed on bytes 10-25 of DNSKEY RDATA.

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: michal/fix-regex-used-for-mangling-druz-dnskey