Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 577
    • Issues 577
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 116
    • Merge requests 116
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • BINDBIND
  • Merge requests
  • !2966

WIP: Make isc_task_pause/isc_task_unpause thread safe.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Witold Krecicki requested to merge wpk/task-pausing-thread-safety into master Jan 28, 2020
  • Overview 14
  • Commits 1
  • Pipelines 4
  • Changes 1

isc_task_pause/unpause were inherently thread-unsafe - a task could be paused only once by one thread, if the task was running while we paused it it led to races. Fix it by making sure that the task will pause if requested to, and by using a 'pause reference counter' to count task pause requests - a task will be unpaused iff all threads unpause it.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wpk/task-pausing-thread-safety