Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 634
    • Issues 634
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 90
    • Merge requests 90
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • BINDBIND
  • Merge requests
  • !3403

Address Coverity warnings in keymgr.c

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Matthijs Mekking requested to merge 1737-coverity-dst_key_gettime-v9_16 into v9_16 Apr 20, 2020
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 2

Coverity showed that the return value of dst_key_gettime was unchecked in INITIALIZE_STATE. If DST_TIME_CREATED was not set we would set the state to be initialized to a weird last changed time.

This would normally not happen because DST_TIME_CREATED is always set. However, we would rather set the time to now (as the comment also indicates) not match the creation time.

The comment on INITIALIZE_STATE also needs updating as we no longer always initialize to HIDDEN.

(cherry picked from commit 564f9dca)

Closes #1737 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 1737-coverity-dst_key_gettime-v9_16