Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 598
    • Issues 598
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 95
    • Merge requests 95
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • BINDBIND
  • Merge requests
  • !4212

Fix the clang 12 warnings with multi-line strings in string arrays

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ondřej Surý requested to merge ondrej/fix-split-string-warnings-clang-12-v9_16 into v9_16 Oct 01, 2020
  • Overview 1
  • Commits 1
  • Pipelines 2
  • Changes 1

The clang 12 has a new warning that warns when using multi-line strings in the string arrays, f.e.:

{ "aa",
  "b"
  "b",
  "cc" }

would generate warning like this:

private_test.c:162:7: error: suspicious concatenation of string literals in an array initialization; did you mean to separate the elements with a comma? [-Werror,-Wstring-concatenation]
                                  "33333/RSASHA1" };
                                  ^
private_test.c:161:7: note: place parentheses around the string literal to silence warning
                                  "Done removing signatures for key "
                                  ^
private_test.c:197:7: error: suspicious concatenation of string literals in an array initialization; did you mean to separate the elements with a comma? [-Werror,-Wstring-concatenation]
                                  "NSEC chain",
                                  ^
private_test.c:196:7: note: place parentheses around the string literal to silence warning
                                  "Removing NSEC3 chain 1 0 30 DEAF / creating "
                                  ^
2 errors generated.

(cherry picked from commit 7b07f229)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: ondrej/fix-split-string-warnings-clang-12-v9_16