Skip to content

Address theoretical resource leak in dns_dt_open()

Mark Andrews requested to merge 2509-cid-281489-resource-leaks-resource_leak-v9_16 into v9_16

dns_dt_open() is not currently called with mode dns_dtmode_unix.

*** CID 281489:  Resource leaks  (RESOURCE_LEAK)
/lib/dns/dnstap.c: 983 in dns_dt_open()
977
978     		if (!dnstap_file(handle->reader)) {
979     			CHECK(DNS_R_BADDNSTAP);
980     		}
981     		break;
982     	case dns_dtmode_unix:
   CID 281489:  Resource leaks  (RESOURCE_LEAK)
   Variable "handle" going out of scope leaks the storage it points to.
983     		return (ISC_R_NOTIMPLEMENTED);
984     	default:
985     		INSIST(0);
986     		ISC_UNREACHABLE();
987     	}
988

(cherry picked from commit 003dd8cc)

Closes #2509 (closed)

Merge request reports