Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 633
    • Issues 633
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 90
    • Merge requests 90
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • BINDBIND
  • Merge requests
  • !5084

Draft: Reduce the number of mctx created in clientmgr

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed Ondřej Surý requested to merge 2433-reduce-clientmgr-memory-contexts-and-tasks-v9_16 into v9_16 May 22, 2021
  • Overview 1
  • Commits 11
  • Pipelines 4
  • Changes 28

The number of memory contexts created in the clientmgr was enormous. It could easily create thousands of memory contexts because the formula was:

nprotocols * ncpus * ninterfaces * CLIENT_NMCTXS_PERCPU (8)

The original goal was to reduce the contention when allocating the memory, but after a while nobody noticed that the amount of memory context allocated would not reduce contention at all.

This commit removes the whole mctxpool and just uses the mctx from clientmgr as the contention will be reduced directly in the allocator.

(cherry picked from commit 798cd300)

Closes #2433 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 2433-reduce-clientmgr-memory-contexts-and-tasks-v9_16