Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 598
    • Issues 598
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 96
    • Merge requests 96
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • BINDBIND
  • Merge requests
  • !5576

fix intermittent resolver test error

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Evan Hunt requested to merge 3013-resolver-test-failure into main Nov 16, 2021
  • Overview 0
  • Commits 1
  • Pipelines 4
  • Changes 2

the resolver test checks that the correct number of fetches have been sent NS rrsets of a given size, but it formerly did so by counting queries received by the authoritative server, which could result in an off-by-one count if one of the queries had been resent due to a timeout or a port number collision.

this commit changes the test to count fetches initiated by the resolver, which should prevent the intermittent test failure, and is the actual datum we were interested in anyway.

Closes #3013 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 3013-resolver-test-failure