Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 569
    • Issues 569
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 99
    • Merge requests 99
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • BINDBIND
  • Merge requests
  • !5590

Resolve #3022: DoH: dig eventually aborts on ALPN negotiation failure when issuing a DoH query (because of dangling handles)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Artem Boldariev requested to merge 3022-doh-fix-dig-crash-on-unexpected-alpn into main Nov 24, 2021
  • Overview 0
  • Commits 4
  • Pipelines 3
  • Changes 4

This commit removes unneeded isc__nmsocket_prep_destroy() call on ALPN negotiation failure, which was eventually causing the TLS handle to leak.

This call is not needed, as not attaching to the transport (TLS) handle should be enough. At this point it seems like a kludge from earlier days of the TLS code.

Closes #3022 (closed)

Edited Nov 24, 2021 by Artem Boldariev
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 3022-doh-fix-dig-crash-on-unexpected-alpn