Skip to content

Resolve #3022: DoH: dig eventually aborts on ALPN negotiation failure when issuing a DoH query (because of dangling handles)

Artem Boldariev requested to merge 3022-doh-fix-dig-crash-on-unexpected-alpn into main

This commit removes unneeded isc__nmsocket_prep_destroy() call on ALPN negotiation failure, which was eventually causing the TLS handle to leak.

This call is not needed, as not attaching to the transport (TLS) handle should be enough. At this point it seems like a kludge from earlier days of the TLS code.

Closes #3022 (closed)

Edited by Artem Boldariev

Merge request reports