Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 577
    • Issues 577
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 116
    • Merge requests 116
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • BINDBIND
  • Merge requests
  • !5599

Shutdown all active TCP connections on error

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ondřej Surý requested to merge 3026-premature-tcp-connection-closure-leaks-fetch-contexts-hang-on-shutdown into main Nov 26, 2021
  • Overview 27
  • Commits 7
  • Pipelines 19
  • Changes 14

When outgoing TCP connection was prematurely terminated (f.e. with connection reset), the dispatch code would not cleanup the resources used by such connection leading to dangling dns_dispentry_t entries.

This branch introduces refactored tcp_recv() code that cleanly shuts down the TCP and cleans up resources on any failure, now also including the cases when the server sends the client garbage DNS message, DNS query or non-matching DNS answer.

Closes #3026 (closed)

Edited Dec 01, 2021 by Ondřej Surý
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 3026-premature-tcp-connection-closure-leaks-fetch-contexts-hang-on-shutdown