Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 577
    • Issues 577
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 116
    • Merge requests 116
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • BINDBIND
  • Merge requests
  • !5612

Restore the fetch context expiry timer

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Michał Kępień requested to merge 3040-restore-the-fetch-context-expiry-timer into main Dec 02, 2021
  • Overview 15
  • Commits 2
  • Pipelines 6
  • Changes 2

the lifetime expiry timer for the fetch context was removed when we switched to using in-band netmgr timeouts. however, it turns out some dependency loops can occur between a fetch and the ADB the validator; these deadlocks were formerly broken when the timer fired, and now there's no timer. we can fix these errors individually, but in the meantime we don't want the server to get hung at shutdown because of dangling fetches.

this commit puts back a single timer, which fires two seconds after the fetch should have completed, and shuts it down. it also logs a message at level ERROR so we know about the problems when they occur.

Closes #3040 (closed)

Edited Dec 03, 2021 by Michał Kępień
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 3040-restore-the-fetch-context-expiry-timer