Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 569
    • Issues 569
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 100
    • Merge requests 100
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • BINDBIND
  • Merge requests
  • !5688

Ensure the correct ordering zone_shutdown() vs zone_gotwritehandle()

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ondřej Surý requested to merge 3071-signed-version-of-an-inline-signed-zone-may-be-dumped-without-unsigned-serial-number-v9_16 into v9_16 Jan 05, 2022
  • Overview 1
  • Commits 2
  • Pipelines 1
  • Changes 3

When the signed version of an inline-signed zone is dumped to disk, the serial number of the unsigned version of the zone is written in the raw-format header so that the contents of the signed zone can be resynchronized after named restart if the unsigned zone file is modified while named is not running (see RT #26676).

In order for the serial number of the unsigned zone to be determined during the dump, zone->raw must be set to a non-NULL value. This should always be the case as long as the signed version of the zone is used for anything by named.

However, under certain circumstances the zone->raw could be set to NULL while the zone is being dumped.

Defer detaching from zone->raw in zone_shutdown() if the zone is in the process of being dumped to disk.

(cherry picked from commit cc1d4e1a)

Closes #3071 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 3071-signed-version-of-an-inline-signed-zone-may-be-dumped-without-unsigned-serial-number-v9_16