Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 525
    • Issues 525
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 95
    • Merge requests 95
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source Projects
  • BINDBIND
  • Merge requests
  • !6163

Run resume_dslookup() from the correct task

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ondřej Surý requested to merge ondrej-use-correct-task-for-resume_dslookup into main Apr 22, 2022
  • Overview 6
  • Commits 1
  • Pipelines 4
  • Changes 1

In rctx_chaseds(), the dns_resolver_createfetch() was created with fctx->task and fctx as callback argument. This would lead to task de-serialization because the fctx->task is initialized with task external to the fetch context. This could become a problem when the shutdown event has been posted at the same time as resume_dslookup() is run created via rctx_chaseds().

Use matching task from the resolver buckets to create internal fetches (e.g. when ev_fctx is used as callback argument).

Edited Apr 26, 2022 by Michał Kępień
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: ondrej-use-correct-task-for-resume_dslookup