Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 530
    • Issues 530
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 102
    • Merge requests 102
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source Projects
  • BINDBIND
  • Merge requests
  • !6343

Resolve "dig +nssearch org crashes when network is unreachable"

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Arаm Sаrgsyаn requested to merge 3207-dig-nssearch-crash-fix into main May 19, 2022
  • Overview 2
  • Commits 2
  • Pipelines 2
  • Changes 3

In special NS search mode, after the initial lookup, dig starts the followup lookup with discovered NS servers in the queries list. If one of those queries then fail, dig, as usual, tries to start the next query in the list, which results in a crash, because the NS search mode is special in a way that the queries are running in parallel, so the next query is usually already started.

Apply some special logic in recv_done() function to deal with the described situation when handling the query result for the NS search mode. Particularly, print a warning message for the failed query, and do not try to start the next query in the list. Also, set a non-zero exit code if all the queries in the followup lookup fail.

Closes #3207 (closed)

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 3207-dig-nssearch-crash-fix