Skip to content

Resolve "CID 356329: Error handling issues in bin/dnssec/dnssec-signzone.c"

Arаm Sаrgsyаn requested to merge 3513-cid-356329-error-handling-in-dnssec-signzone.c into main

Improve the error handling by checking the isc_task_create() function's return value.

CID 356329:

/bin/dnssec/dnssec-signzone.c: 3732 in main()
3726     	if (directory == NULL) {
3727     		directory = ".";
3728     	}
3729
3730     	isc_managers_create(&mctx, ntasks, &loopmgr, &netmgr, &taskmgr);
3731
>>>     CID 356329:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "isc__task_create" without checking return value (as is done elsewhere 16 out of 18 times).
3732     	isc_task_create(taskmgr, &write_task, 0);
3733
3734     	result = dst_lib_init(mctx, engine);
3735     	if (result != ISC_R_SUCCESS) {
3736     		fatal("could not initialize dst: %s",
3737

Closes #3513 (closed)

Merge request reports