Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 589
    • Issues 589
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 95
    • Merge requests 95
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • BINDBIND
  • Merge requests
  • !6851

Resolve "CID 357292: Improper use of negative value in lib/isc/netmgr/tcp.c"

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Arаm Sаrgsyаn requested to merge 3574-cid-357292-improper-use-of-negative-value-in-tcp.c into main Oct 04, 2022
  • Overview 2
  • Commits 1
  • Pipelines 3
  • Changes 1

Remove a superfluous check of sock->fd against -1.

The check comes from the times when tcp_connect_direct() was performing isc__nm_socket() by its own, but currently at this point the isc__nm_socket() is already passed and sock->fd cannot be -1.

Closes #3574 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 3574-cid-357292-improper-use-of-negative-value-in-tcp.c