Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 610
    • Issues 610
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 87
    • Merge requests 87
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • BINDBIND
  • Merge requests
  • !6893

Resolve "ADB quota might not be decremented"

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Arаm Sаrgsyаn requested to merge 3598-adb-quota-might-not-be-decremented into main Oct 11, 2022
  • Overview 9
  • Commits 4
  • Pipelines 6
  • Changes 3

It is currently possible that dns_adb_endudpfetch() is not called in fctx_cancelquery() for a UDP query, which results in quotas not being adjusted back.

Always call dns_adb_endudpfetch() for UDP queries

Also, in the cleanup code of fctx_query() function there is a code path where 'query' is linked to 'fctx' and it is being destroyed.

Make sure that 'query' is unlinked before destroying it.

Closes #3598 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 3598-adb-quota-might-not-be-decremented