Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 610
    • Issues 610
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 87
    • Merge requests 87
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • BINDBIND
  • Merge requests
  • !6895

Ignore additional return codes in the netmgr unit tests

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ondřej Surý requested to merge 3601-ignore-connection_reset-in-listen_send_cb into main Oct 12, 2022
  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 1

There was inconsistency in which error codes would get accepted and ignored in the network manager unit test callbacks. Add following results, so we just detach the handle instead of causing assertion failure:

  • ISC_R_SHUTTINGDOWN - when the network manager is shutting down
  • ISC_R_CANCELED - the socket has been shut down
  • ISC_R_EOF - the (TCP) communication has ended on the other side
  • ISC_R_CONNECTIONRESET - the TCP connection was reset

This should fix some of the spurious unit test failures.

Closes #3601 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 3601-ignore-connection_reset-in-listen_send_cb