Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 633
    • Issues 633
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 88
    • Merge requests 88
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • BINDBIND
  • Merge requests
  • !6943

Serialize the HTTP/1.1 statschannel requests

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Ondřej Surý requested to merge 3270-serialize-statschannel-http-requests into 3270-use-curl-in-statschannel-system-test Oct 18, 2022
  • Overview 8
  • Commits 2
  • Pipelines 6
  • Changes 1

The statschannel truncated test still terminates abruptly sometimes and it doesn't return the answer for the first query. This might happen when the second process_request() discovers there's not enough space before the sending is complete and the connection is terminated before the client gets the data.

Change the isc_http, so it pauses the reading when it receives the data and resumes it only after the sending has completed or there's incomplete request waiting for more data.

This makes the request processing slightly less efficient, but also less taxing for the server, because previously all requests that has been received via single TCP read would be processed in the loop and the sends would be queued after the read callback has processed a full buffer.

Closes #3270 (closed)

Edited Oct 19, 2022 by Ondřej Surý
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 3270-serialize-statschannel-http-requests