Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 632
    • Issues 632
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 87
    • Merge requests 87
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • BINDBIND
  • Merge requests
  • !6987

TLS Stream: do not use isc_nm_read_stop() during I/O

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed Artem Boldariev requested to merge artem-tlsstream-do-not-use-isc-nm-read-stop-when-doing-io into main Oct 26, 2022
  • Overview 3
  • Commits 1
  • Pipelines 1
  • Changes 1

Originally, the code used isc_nm_pauseread(). During adaptation to the latest Network Manager changes, it has been replaced with isc_nm_read_stop(). However, there is no need in that as currently in order to continue reading, we need to explicitly call isc_nm_read() on the underlying TCP socket. So, this call is superfluous at the moment, if not harmful, considering that other parts of the code appear to be properly adapted.

The isc_nm_read_stop() is known for causing troubles (assertion failures) in the Stream DNS branch when paired with new read timer control functionality there, in the development branch it might be responsible for some intermittent failures too.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: artem-tlsstream-do-not-use-isc-nm-read-stop-when-doing-io