Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 633
    • Issues 633
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 88
    • Merge requests 88
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • BINDBIND
  • Merge requests
  • !7360

XoT: properly handle the case when checking for ALPN failed

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Artem Boldariev requested to merge 3767-dot-no-alpn-transfer-shutdown-crash into main Jan 12, 2023
  • Overview 4
  • Commits 2
  • Pipelines 3
  • Changes 2

During XoT it is important to check for "dot" ALPN tag to be negotiated (according to the RFC 9103). We were doing that, however, the situation was not handled properly, leading to non-cancelled zone transfers that would crash (abort()) BIND on shutdown.

In this particular case 'result' might equal 'ISC_R_SUCCESS'. When this is the case, the part of the code supposed to handle failures will not cancel the zone transfer.

This situation cannot happen when BIND is a secondary of other BIND instance. Only primaries following the RFC not closely enough could trigger such a behaviour.

Closes #3767 (closed)

Edited Jan 31, 2023 by Michal Nowak
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 3767-dot-no-alpn-transfer-shutdown-crash