Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 598
    • Issues 598
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 95
    • Merge requests 95
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • BINDBIND
  • Merge requests
  • !7389

[9.16] Detach the views in zone_shutdown(), not in zone_free()

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ondřej Surý requested to merge 3801-reduce-memory-bloat-caused-by-delayed-view-detach-v9_16 into v9_16 Jan 17, 2023
  • Overview 1
  • Commits 3
  • Pipelines 1
  • Changes 4

The .view (and possibly .prev_view) would be kept attached to the removed zone until the zone is fully removed from the memory in zone_free(). If this process is delayed because server is busy something else like doing constant rndc reconfig, it could take seconds to detach the view, possibly keeping multiple dead views in the memory. This could quickly lead to a massive memory bloat.

Release the views early in the zone_shutdown() call, and don't wait until the zone is freed.

(cherry picked from commit 13bb8212)

Closes #3801 (closed)

Backport of MR !7382 (merged)

Edited Jan 17, 2023 by Ondřej Surý
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 3801-reduce-memory-bloat-caused-by-delayed-view-detach-v9_16