Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 605
    • Issues 605
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 88
    • Merge requests 88
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • BINDBIND
  • Merge requests
  • !7595

Fix DNSRPS code after struct dns_db refactoring

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Michał Kępień requested to merge 3891-fix-dnsrps-code into main Feb 24, 2023
  • Overview 7
  • Commits 1
  • Pipelines 2
  • Changes 1

Commits ffa4757c and 77e7eac5 inadvertently broke DNSRPS-enabled builds:

  • the new member of struct dns_db that holds a reference count for the database is called 'references', not 'refcount',

  • a syntax error was introduced in the designated initializer for 'rpsdb_rdataset_methods',

  • rpsdb_destroy() no longer takes a 'dbp' argument.

Address all of the above issues to make DNSRPS-enabled builds work again.

We should preferably merge this before the March code freeze as the breakage was introduced in this release cycle.

See #3882 (closed)/!7558 (merged)

See also !7601 (merged) for an attempt at detecting the type of breakage addressed by this MR in advance.

Closes #3891 (closed)

Edited Feb 24, 2023 by Michał Kępień
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 3891-fix-dnsrps-code