Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 610
    • Issues 610
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 87
    • Merge requests 87
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • BINDBIND
  • Merge requests
  • !7632

Fix view's zones reverting bug during reconfiguration

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Arаm Sаrgsyаn requested to merge 3911-reconfig-zone-view-revert-bugfix into main Mar 01, 2023
  • Overview 1
  • Commits 3
  • Pipelines 2
  • Changes 5

During reconfiguration, the configure_view() function reverts the configured zones to the previous view in case if there is an error.

It uses the 'zones_configured' boolean variable to decide whether it is required to revert the zones, i.e. the error happened after all the zones were successfully configured.

The problem is that it does not account for the case when an error happens during the configuration of one of the zones (not the first), in which case there are zones that are already configured for the new view (and they need to be reverted), and there are zones that are not (starting from the failed one).

Since 'zones_configured' remains 'false', the configured zones are not reverted.

Replace the 'zones_configured' variable with a pointer to the latest successfully configured zone configuration element, and when reverting, revert up to and including that zone.

Closes #3911 (closed)

Edited Mar 01, 2023 by Arаm Sаrgsyаn
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 3911-reconfig-zone-view-revert-bugfix