Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 633
    • Issues 633
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 87
    • Merge requests 87
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • BINDBIND
  • Merge requests
  • !7687

DoT: remove TLS-related kludge in isc__nmsocket_connecttimeout_cb()

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Artem Boldariev requested to merge 3867-fix-xot-hang into v9_18 Mar 14, 2023
  • Overview 0
  • Commits 3
  • Pipelines 2
  • Changes 3

This commit ensures that 'sock->tls.pending_req' is not getting nullified during TLS connection timeout callback as it prevents the connection callback being called when connecting was not successful.

We expect 'isc__nm_failed_connect_cb() to be called from 'isc__nm_tlsdns_shutdown()' when establishing connections was successful, but with 'sock->tls.pending_req' nullified that will not happen.

The code removed most likely was required in older iterations of the NM, but to me it seems that now it does only harm. One of the well know pronounced effects is leading to irrecoverable zone transfer hangs via TLS.

Closes #3867 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 3867-fix-xot-hang