Skip to content

Fix xfrin_connect_done() error paths

Ondřej Surý requested to merge 3989-remove-dead-code-from-dns_xfrin into main

The xfrin_connect_done() had several problems:

  • it would not add the server to unreachable table in case of failure coming from the dispatch [GL #3989 (closed)]

  • if dns_dispatch_checkperm() disallowed the connection, the xfr would be left undetached

  • if xfrin_send_request() failed to send the request, the xfr would be left undetached

All of these have been fixed in this commit.

Closes #3989 (closed)

Edited by Ondřej Surý

Merge request reports