Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 633
    • Issues 633
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 87
    • Merge requests 87
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • BINDBIND
  • Merge requests
  • !7817

[9.16] Do not retry in resolution_fails() on timeout

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Michal Nowak requested to merge 3916-legacy-test-no-retries-in-resolution_fails-9.16 into bind-9.16 Apr 06, 2023
  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 1

At the time of test number (19), there were 10 "sending packet to 10.53.0.7" lines in the "legacy/ns1/named.run" file; usually, only seven are present:

I:legacy:checking recursive lookup to edns 512 + no tcp server does not cause query loops (19)
I:legacy:ns1 sent 10 queries to ns7, expected less than 10
I:legacy:failed

Those three can be attributed to tests "8", "10", and "18", where the dig of "resolution_fails()" retried after a timeout to succeed with "status: SERVFAIL" subsequently, as seen in each of dig.out.test{8,10,18} files.

;; communications error to 10.53.0.1#13093: timed out

; <<>> DiG 9.19.12-dev <<>> -p 13093 +tcp @10.53.0.1 edns512-notcp. TXT
; (1 server found)
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: SERVFAIL, id: 5368
;; flags: qr rd ra; QUERY: 1, ANSWER: 0, AUTHORITY: 0, ADDITIONAL: 1

This retry is unnecessary because "resolution_fails()" considers timeout a positive result.

(cherry picked from commit e05460c8)

Closes #3916 (closed)

Backport of MR !7814 (merged)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 3916-legacy-test-no-retries-in-resolution_fails-9.16