Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 634
    • Issues 634
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 90
    • Merge requests 90
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • BINDBIND
  • Merge requests
  • !8003

Fix extra detach when dns_validator create_fetch() detects deadlock

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Ondřej Surý requested to merge 4115-fix-extra-dns_validator-detach into main Jun 06, 2023
  • Overview 6
  • Commits 2
  • Pipelines 6
  • Changes 3

When create_fetch() in the dns_validator unit detects deadlock, it returns DNS_R_NOVALIDSIG, but it didn't attach to the validator. The other condition to returning result != ISC_R_SUCCESS would be error from dns_resolver_createfetch(). The caller (in two places out of three) would detect the error condition and always detach from the validator.

Move the dns_validator_detach() on dns_resolver_createfetch() error condition to create_fetch() function and cleanup the extra detaches in seek_dnskey() and get_dsset().

Closes #4115 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 4115-fix-extra-dns_validator-detach