Skip to content

Cleanup the dns_catz unit API

Ondřej Surý requested to merge ondrej/cleanup-cruft-in-dns_catz into main
  1. Change the _new, _add and _copy functions to return the new object instead of returning 'void' (or always ISC_R_SUCCESS)

  2. Cleanup the isc_ht_find() + isc_ht_add() usage - the code is always locked with catzs->lock (mutex), so when isc_ht_find() returns ISC_R_NOTFOUND, the isc_ht_add() must always succeed. This in turn allowed to rip out large chunk from named_server unit because the dns_catz_add_zone() would never fail even before the refactoring, it was just a bit muddled.

Merge request reports