Skip to content

Increase TCP4Clients/TCP6Clients after point of no failure

I have opted to delay when the counter increases instead of decreasing the counter again. The delay should be insignificant and ensures only successfully connected clients are counted. Testing it seems to show correct results.

Failing to accept TCP/TLS connections in 9.18 detaches the quota in isc__nm_failed_accept_cb, causing TCP4Clients and TCP6Clients statistics to not decrease inside cleanup.

Fix by increasing the counter after the point of no failure but before handling statistics through the client's socket is no longer valid.

Closes #4742 (closed)

Merge request reports