Skip to content

fix: dev: Don't skip the counting if fcount_incr() is called with force==true (v2)

Ondřej Surý requested to merge 4786-forced-fcount_incr-should-still-increment-count-and-allowed-fix into main

The fcount_incr() was not increasing counter->count when force was set to true, but fcount_decr() would try to decrease the counter leading to underflow and assertion failure. Swap the order of the arguments in the condition, so the !force is evaluated after incrementing the .count.

Closes #4846 (closed)

Edited by Ondřej Surý

Merge request reports