Skip to content

[9.20] fix: dev: Fix the assertion failure in the isc_hashmap iterator

bind-team-rw-api-rw-repo requested to merge backport-4838-fix-assertion-failure-in-hashmap-deletion-iterator-9.20 into bind-9.20

When the round robin hashing reorders the map entries on deletion, we were adjusting the iterator table size only when the reordering was happening at the internal table boundary. The iterator table size had to be reduced by one to prevent seeing the entry that resized on position [0] twice because it migrated to [iter->size - 1] position.

However, the same thing could happen when the same entry migrates a second time from [iter->size - 1] to [iter->size - 2] position (and so on) because the check that we are manipulating the entry just in the [0] position was insufficient. Instead of checking the position [pos == 0], we now check that the [pos % iter->size == 0], thus ignoring all the entries that might have moved back to the end of the internal table.

Closes #4838 (closed)

Backport of MR !9292 (merged)

Merge request reports