Skip to content

chg: usr: Revert "Fix NSEC3 closest encloser lookup for names with empty non-terminals"

Matthijs Mekking requested to merge revert-4950-bind-logs-expected-covering-nsec3-got-an-exact-match-9.18 into bind-9.18

The fix for #4950 (closed) should have never been backported to 9.18. Revert the change.

This reverts MR !9632 (merged)

History: A performance improvement for NSEC3 closest encloser lookups (#4460 (closed)) was introduced (in MR !9436 (merged)) and backported to 9.20 (MR !9438 (merged)) and to 9.18 in (MR !9439 (merged)). It was released in 9.18.30 (and 9.20.2 and 9.21.1).

There was a bug in the code (#4950 (closed)), so we reverted the change in !9611 (merged), !9613 (merged) and !9614 (merged) (not released).

Then a new attempt was merged in main (MR !9610 (merged)) and backported to 9.20 (MR !9631 (merged)) and 9.18 (MR !9632 (merged)). The latter should not have been backported.

Furthermore, the initial MR used the wrong MR title so the change was never added to the release note. This is done in main with MR !9598 (merged) and backports to 9.20 (MR !9615 (merged)) and 9.18 (MR !9616 (merged)).

The new release notes for 9.21 and 9.20 should probably say that the bug is fixed. The new release notes for 9.18 should probably say that the change is reverted.

Merge request reports