... | ... | @@ -33,6 +33,20 @@ For minor changes, it isn't always necessary to create an issue in Gitlab; just |
|
|
Several review-related labels have been added to Gitlab merge requests:
|
|
|
|
|
|
1. Review: Set by the author when the branch is ready to be reviewed.
|
|
|
1. Merge OK: Set by the reviewer when the code is okay.
|
|
|
1. LGTM (Merge OK): Set by the reviewer when the code is okay.
|
|
|
1. Needs cleanup: Can be set by either the author or the reviewer; this indicates that regardless of the current state of the code, the branch still needs to be cleaned up -- for example, by squashing commits in `git rebase -i`.
|
|
|
1. Author merge: The author wishes to merge this branch personally and requests that no one else click the merge button, regardless of whether it's deemed ready.
|
|
|
|
|
|
##### Code review
|
|
|
|
|
|
A merge request has an "Assignee" field and a "Reviewer" field. If you are assigned to one of those it will show up in "Your Merge Requests".
|
|
|
|
|
|
If the "Reviewer" field is set the next action item is for that person, otherwise the next action item is for the assignee.
|
|
|
|
|
|
When you create a merge request, set the "Assignee" to yourself. Typically you are the one that is responsible for merging it eventually. You can change the "Assignee" if someone is taking over the work, but in most cases the one who created the merge request will stay the assignee.
|
|
|
|
|
|
The "Reviewer" label is initially left Unassigned. A merge request with the "Review" label set and no assigned reviewer is awaiting review.
|
|
|
|
|
|
If you start reviewing a merge request, assign yourself. You are now the reviewer. When you are done with the review, you can unassign yourself. This means the action item is back to the "Assignee".
|
|
|
|
|
|
The assignee can also set the "Reviewer" field to indicate it requests code review from a specific person. |
|
|
\ No newline at end of file |