Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
D
dhcp
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 64
    • Issues 64
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 16
    • Merge Requests 16
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • ISC Open Source Projects
  • dhcp
  • Issues
  • #68

Closed
Open
Opened Dec 13, 2019 by Thomas Markwalder@tmarkMaintainer

Changing 'd' content type to RFC 1035 name broke omapi-key parsing

We overlooked three server options with 'd' format: omapi-key, ldap-port, ldap-init-retry. Changing 'd' under #2 (closed) from being handled as text, breaks the ability to match omapi-key to any parsed keys. When server config file defines a TSIG key to use with omapi such as shown below:

# define a key
key  toms-key {
        algorithm hmac-md5;
        secret <some key here>;
}

# tell the server to use the key for omapi
omapi-key toms-key;

With a "d" option format for omapi-key, during configuration parsing the server will emit the error "OMAPI key : not found" and then exit. This is because the value for omapi-key option when evaluated by the server is in RFC 1035 format "\007toms-key" rather than plain text "toms-key". Changing the format to "t" will solve the problem. This should work for all three as prior #2 (closed), "d" format content equivalent to plain text.

This will need to go to v4_1_esv too.

Edited Dec 13, 2019 by Thomas Markwalder
Assignee
Assign to
4.4.2
Milestone
4.4.2
Assign milestone
Time tracking
None
Due date
None
Reference: isc-projects/dhcp#68