compilation warnings
Reported by @razvan during sanity checks
minor:
In file included from simple_parser_unittest.cc:11:
In function ‘testing::AssertionResult testing::internal::CmpHelperEQ(const char*, const char*, const T1&, const T2&) [with T1 = int; T2 = long int]’,
inlined from ‘static testing::AssertionResult testing::internal::EqHelper::Compare(const char*, const char*, const T1&, const T2&) [with T1 = int; T2 = long int; typename std::enable_if<((! std::is_integral<_Tp>::value) || (! std::is_pointer<_Dp>::value))>::type* <anonymous> = 0]’ at /home/razvan/isc/git/googletest/googletest//include/gtest/gtest.h:1568:64,
inlined from ‘virtual void SimpleParserTest_getInteger_Test::TestBody()’ at simple_parser_unittest.cc:258:5:
/home/razvan/isc/git/googletest/googletest//include/gtest/gtest.h:1541:11: warning: ‘x’ may be used uninitialized [-Wmaybe-uninitialized]
1541 | if (lhs == rhs) {
| ~~~~^~~~~~
simple_parser_unittest.cc: In member function ‘virtual void SimpleParserTest_getInteger_Test::TestBody()’:
simple_parser_unittest.cc:254:13: note: ‘x’ declared here
254 | int64_t x;
| ^
In file included from option_custom_unittest.cc:13:
In function ‘testing::AssertionResult testing::internal::CmpHelperEQ(const char*, const char*, const T1&, const T2&) [with T1 = int; T2 = short unsigned int]’,
inlined from ‘static testing::AssertionResult testing::internal::EqHelper::Compare(const char*, const char*, const T1&, const T2&) [with T1 = int; T2 = short unsigned int; typename std::enable_if<((! std::is_integral<_Tp>::value) || (! std::is_pointer<_Dp>::value))>::type* <anonymous> = 0]’ at /home/razvan/isc/git/googletest/googletest//include/gtest/gtest.h:1568:64,
inlined from ‘virtual void {anonymous}::OptionCustomTest_setUint16DataArray_Test::TestBody()’ at option_custom_unittest.cc:1742:5:
/home/razvan/isc/git/googletest/googletest//include/gtest/gtest.h:1541:11: warning: ‘value0’ may be used uninitialized [-Wmaybe-uninitialized]
1541 | if (lhs == rhs) {
| ~~~~^~~~~~
option_custom_unittest.cc: In member function ‘virtual void {anonymous}::OptionCustomTest_setUint16DataArray_Test::TestBody()’:
option_custom_unittest.cc:1740:14: note: ‘value0’ declared here
1740 | uint16_t value0;
| ^~~~~~
In function ‘testing::AssertionResult testing::internal::CmpHelperEQ(const char*, const char*, const T1&, const T2&) [with T1 = int; T2 = short unsigned int]’,
inlined from ‘static testing::AssertionResult testing::internal::EqHelper::Compare(const char*, const char*, const T1&, const T2&) [with T1 = int; T2 = short unsigned int; typename std::enable_if<((! std::is_integral<_Tp>::value) || (! std::is_pointer<_Dp>::value))>::type* <anonymous> = 0]’ at /home/razvan/isc/git/googletest/googletest//include/gtest/gtest.h:1568:64,
inlined from ‘virtual void {anonymous}::OptionCustomTest_setUint16DataArray_Test::TestBody()’ at option_custom_unittest.cc:1745:5:
/home/razvan/isc/git/googletest/googletest//include/gtest/gtest.h:1541:11: warning: ‘value1’ may be used uninitialized [-Wmaybe-uninitialized]
1541 | if (lhs == rhs) {
| ~~~~^~~~~~
option_custom_unittest.cc: In member function ‘virtual void {anonymous}::OptionCustomTest_setUint16DataArray_Test::TestBody()’:
option_custom_unittest.cc:1743:14: note: ‘value1’ declared here
1743 | uint16_t value1;
| ^~~~~~
In function ‘testing::AssertionResult testing::internal::CmpHelperEQ(const char*, const char*, const T1&, const T2&) [with T1 = int; T2 = short unsigned int]’,
inlined from ‘static testing::AssertionResult testing::internal::EqHelper::Compare(const char*, const char*, const T1&, const T2&) [with T1 = int; T2 = short unsigned int; typename std::enable_if<((! std::is_integral<_Tp>::value) || (! std::is_pointer<_Dp>::value))>::type* <anonymous> = 0]’ at /home/razvan/isc/git/googletest/googletest//include/gtest/gtest.h:1568:64,
inlined from ‘virtual void {anonymous}::OptionCustomTest_setUint16DataArray_Test::TestBody()’ at option_custom_unittest.cc:1748:5:
/home/razvan/isc/git/googletest/googletest//include/gtest/gtest.h:1541:11: warning: ‘value2’ may be used uninitialized [-Wmaybe-uninitialized]
1541 | if (lhs == rhs) {
| ~~~~^~~~~~
option_custom_unittest.cc: In member function ‘virtual void {anonymous}::OptionCustomTest_setUint16DataArray_Test::TestBody()’:
option_custom_unittest.cc:1746:14: note: ‘value2’ declared here
1746 | uint16_t value2;
| ^~~~~~
In function ‘testing::AssertionResult testing::internal::CmpHelperEQ(const char*, const char*, const T1&, const T2&) [with T1 = int; T2 = short unsigned int]’,
inlined from ‘static testing::AssertionResult testing::internal::EqHelper::Compare(const char*, const char*, const T1&, const T2&) [with T1 = int; T2 = short unsigned int; typename std::enable_if<((! std::is_integral<_Tp>::value) || (! std::is_pointer<_Dp>::value))>::type* <anonymous> = 0]’ at /home/razvan/isc/git/googletest/googletest//include/gtest/gtest.h:1568:64,
inlined from ‘virtual void {anonymous}::OptionCustomTest_setRecordData_Test::TestBody()’ at option_custom_unittest.cc:2047:5:
/home/razvan/isc/git/googletest/googletest//include/gtest/gtest.h:1541:11: warning: ‘value0’ may be used uninitialized [-Wmaybe-uninitialized]
1541 | if (lhs == rhs) {
| ~~~~^~~~~~
option_custom_unittest.cc: In member function ‘virtual void {anonymous}::OptionCustomTest_setRecordData_Test::TestBody()’:
option_custom_unittest.cc:2045:14: note: ‘value0’ declared here
2045 | uint16_t value0;
| ^~~~~~
In function ‘testing::AssertionResult testing::internal::CmpHelperEQ(const char*, const char*, const T1&, const T2&) [with T1 = int; T2 = short unsigned int]’,
inlined from ‘static testing::AssertionResult testing::internal::EqHelper::Compare(const char*, const char*, const T1&, const T2&) [with T1 = int; T2 = short unsigned int; typename std::enable_if<((! std::is_integral<_Tp>::value) || (! std::is_pointer<_Dp>::value))>::type* <anonymous> = 0]’ at /home/razvan/isc/git/googletest/googletest//include/gtest/gtest.h:1568:64,
inlined from ‘virtual void {anonymous}::OptionCustomTest_setRecordArrayData_Test::TestBody()’ at option_custom_unittest.cc:2138:5:
/home/razvan/isc/git/googletest/googletest//include/gtest/gtest.h:1541:11: warning: ‘value0’ may be used uninitialized [-Wmaybe-uninitialized]
1541 | if (lhs == rhs) {
| ~~~~^~~~~~
option_custom_unittest.cc: In member function ‘virtual void {anonymous}::OptionCustomTest_setRecordArrayData_Test::TestBody()’:
option_custom_unittest.cc:2136:14: note: ‘value0’ declared here
2136 | uint16_t value0;
| ^~~~~~
CXX libdhcp___unittests-pkt4_unittest.o
In function ‘testing::AssertionResult testing::internal::CmpHelperEQ(const char*, const char*, const T1&, const T2&) [with T1 = int; T2 = short unsigned int]’,
inlined from ‘static testing::AssertionResult testing::internal::EqHelper::Compare(const char*, const char*, const T1&, const T2&) [with T1 = int; T2 = short unsigned int; typename std::enable_if<((! std::is_integral<_Tp>::value) || (! std::is_pointer<_Dp>::value))>::type* <anonymous> = 0]’ at /home/razvan/isc/git/googletest/googletest//include/gtest/gtest.h:1568:64,
inlined from ‘virtual void {anonymous}::OptionCustomTest_unpackRecordArray_Test::TestBody()’ at option_custom_unittest.cc:2373:5:
/home/razvan/isc/git/googletest/googletest//include/gtest/gtest.h:1541:11: warning: ‘value0’ may be used uninitialized [-Wmaybe-uninitialized]
1541 | if (lhs == rhs) {
| ~~~~^~~~~~
option_custom_unittest.cc: In member function ‘virtual void {anonymous}::OptionCustomTest_unpackRecordArray_Test::TestBody()’:
option_custom_unittest.cc:2371:14: note: ‘value0’ declared here
2371 | uint16_t value0;
| ^~~~~~
In member function ‘std::basic_ostream<_CharT, _Traits>::__ostream_type& std::basic_ostream<_CharT, _Traits>::operator<<(long unsigned int) [with _CharT = char; _Traits = std::char_traits<char>]’,
inlined from ‘static void testing::internal::StreamPrinter::PrintValue(const T&, std::ostream*) [with T = long unsigned int; <template-parameter-1-2> = void]’ at /home/razvan/isc/git/googletest/googletest//include/gtest/gtest-printers.h:230:9,
inlined from ‘void testing::internal::PrintWithFallback(const T&, std::ostream*) [with T = long unsigned int]’ at /home/razvan/isc/git/googletest/googletest//include/gtest/gtest-printers.h:314:22,
inlined from ‘void testing::internal::PrintTo(const T&, std::ostream*) [with T = long unsigned int]’ at /home/razvan/isc/git/googletest/googletest//include/gtest/gtest-printers.h:427:30,
inlined from ‘static void testing::internal::UniversalPrinter<T>::Print(const T&, std::ostream*) [with T = long unsigned int]’ at /home/razvan/isc/git/googletest/googletest//include/gtest/gtest-printers.h:593:12,
inlined from ‘void testing::internal::UniversalPrint(const T&, std::ostream*) [with T = long unsigned int]’ at /home/razvan/isc/git/googletest/googletest//include/gtest/gtest-printers.h:783:30,
inlined from ‘static void testing::internal::UniversalTersePrinter<T>::Print(const T&, std::ostream*) [with T = long unsigned int]’ at /home/razvan/isc/git/googletest/googletest//include/gtest/gtest-printers.h:711:19,
inlined from ‘std::string testing::PrintToString(const T&) [with T = long unsigned int]’ at /home/razvan/isc/git/googletest/googletest//include/gtest/gtest-printers.h:821:44,
inlined from ‘static std::string testing::internal::FormatForComparison<ToPrint, OtherOperand>::Format(const ToPrint&) [with ToPrint = long unsigned int; OtherOperand = int]’ at /home/razvan/isc/git/googletest/googletest//include/gtest/gtest-printers.h:336:42,
inlined from ‘std::string testing::internal::FormatForComparisonFailureMessage(const T1&, const T2&) [with T1 = long unsigned int; T2 = int]’ at /home/razvan/isc/git/googletest/googletest//include/gtest/gtest-printers.h:401:51,
inlined from ‘testing::AssertionResult testing::internal::CmpHelperEQFailure(const char*, const char*, const T1&, const T2&) [with T1 = int; T2 = long unsigned int]’ at /home/razvan/isc/git/googletest/googletest//include/gtest/gtest.h:1525:25,
inlined from ‘testing::AssertionResult testing::internal::CmpHelperEQ(const char*, const char*, const T1&, const T2&) [with T1 = int; T2 = long unsigned int]’ at /home/razvan/isc/git/googletest/googletest//include/gtest/gtest.h:1545:69,
inlined from ‘static testing::AssertionResult testing::internal::EqHelper::Compare(const char*, const char*, const T1&, const T2&) [with T1 = int; T2 = long unsigned int; typename std::enable_if<((! std::is_integral<_Tp>::value) || (! std::is_pointer<_Dp>::value))>::type* <anonymous> = 0]’ at /home/razvan/isc/git/googletest/googletest//include/gtest/gtest.h:1568:64,
inlined from ‘virtual void {anonymous}::HttpRequestTest_includeHeaders_Test::TestBody()’ at request_unittests.cc:146:5:
/usr/include/c++/12/ostream:171:25: warning: ‘content_length’ may be used uninitialized [-Wmaybe-uninitialized]
171 | { return _M_insert(__n); }
| ~~~~~~~~~^~~~~
request_unittests.cc: In member function ‘virtual void {anonymous}::HttpRequestTest_includeHeaders_Test::TestBody()’:
request_unittests.cc:142:14: note: ‘content_length’ was declared here
142 | uint64_t content_length;
| ^~~~~~~~~~~~~~
In file included from ../../../../src/lib/testutils/test_to_element.h:12,
from dhcp_parsers_unittest.cc:36:
In function ‘testing::AssertionResult testing::internal::CmpHelperEQ(const char*, const char*, const T1&, const T2&) [with T1 = int; T2 = unsigned char]’,
inlined from ‘static testing::AssertionResult testing::internal::EqHelper::Compare(const char*, const char*, const T1&, const T2&) [with T1 = int; T2 = unsigned char; typename std::enable_if<((! std::is_integral<_Tp>::value) || (! std::is_pointer<_Dp>::value))>::type* <anonymous> = 0]’ at /home/razvan/isc/git/googletest/googletest//include/gtest/gtest.h:1568:64,
inlined from ‘virtual void {anonymous}::ParseConfigTest_encapsulatedOptionData_Test::TestBody()’ at dhcp_parsers_unittest.cc:1313:5:
/home/razvan/isc/git/googletest/googletest//include/gtest/gtest.h:1541:11: warning: ‘flags’ may be used uninitialized [-Wmaybe-uninitialized]
1541 | if (lhs == rhs) {
| ~~~~^~~~~~
dhcp_parsers_unittest.cc: In member function ‘virtual void {anonymous}::ParseConfigTest_encapsulatedOptionData_Test::TestBody()’:
dhcp_parsers_unittest.cc:1299:13: note: ‘flags’ declared here
1299 | uint8_t flags;
| ^~~~~
communication_state_unittest.cc:213:1: warning: ‘void {anonymous}::CommunicationStateTest::partnerStateUnavailableTest()’ defined but not used [-Wunused-function]
213 | CommunicationStateTest::partnerStateUnavailableTest() {
| ^~~~~~~~~~~~~~~~~~~~~~