Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Kea Kea
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 558
    • Issues 558
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 59
    • Merge requests 59
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • KeaKea
  • Merge requests
  • !1778

Draft: fix some oversights with vendor options

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Andrei Pavel requested to merge 2517-fix-some-oversights into master Aug 29, 2022
  • Overview 2
  • Commits 2
  • Pipelines 0
  • Changes 2

Closes #2517 (closed).

The statement with the addition to classes that does nothing is worrying. Also, less impactful, let's use uint32_t for vendor ID like in all other places. These were comments added by @djt in !1758 (merged).

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 2517-fix-some-oversights