Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Kea Kea
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 559
    • Issues 559
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 62
    • Merge requests 62
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • KeaKea
  • Merge requests
  • !1862

Resolve "MtTcpListenerMgr::stop() destroys listener without stopping it first"

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Thomas Markwalder requested to merge 2655-implement-mtleasequerylistenermgr into master Dec 02, 2022
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 2

Closes #2655 (closed)

MtTcpListenerMgr::stop() doesn't stop the the listener instance before destroying it. This can leave the socket still in use at the OS level. I found this while testing in-progress class, MtLeaseQueryListenerMgr, one UT would pass, a subsequent tests would fail with listener failing to start due to address already in-use. The HTTP class hierarchy from which these were modeled does stop it, so this got dropped.

Edited Dec 02, 2022 by Thomas Markwalder
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 2655-implement-mtleasequerylistenermgr