Skip to content

Resolve "kea-admin tool doesn't support -P argument to specify port for remote mysql connection"

Andrei Pavel requested to merge 2882-kea-admin-tool-doesn-t-support-p-argument-to-specify-port-for-remote-mysql-connection into master

Closes #2882 (closed).

  • 59e690e3 fix -P|--port flag in kea-admin

  • 2719718c fix pgsql_unused_subnet_id_test

    Adding --set ON_ERROR_STOP=1 to pgsql_upgrade made pgsql_unused_subnet_id fail while attempting to upgrade a 4.0 schema with some data to the latest schema.

    Processing src/share/database/scripts/pgsql/upgrade_003.3_to_004.0.sh file...
Schema upgraded to 4.0
NOTICE:  index "key_dhcp4_ipv4_address_subnet_id" does not exist, skipping
ERROR:  insert or update on table "dhcp6_options" violates foreign key constraint "fk_dhcp6_options_subnet"
DETAIL:  Key (dhcp6_subnet_id)=(6) is not present in table "dhcp6_subnet".

    The test is not trying to cover a negative scenario as far as I can tell. It seems that in the end, the schema ended up being upgraded to the target version of the last script that worked without errors, in this case 7.0. It tried to advance to other upgrade scripts, but skipped them because of versions mismatch.

    Processing src/share/database/scripts/pgsql/upgrade_007_to_008.sh file...
Processing src/share/database/scripts/pgsql/upgrade_008_to_009.sh file...
This script upgrades 8.0 to 9.0. Reported version is 7.0. Skipping upgrade.
[...]
Processing src/share/database/scripts/pgsql/upgrade_023_to_024.sh file...
This script upgrades 23.0 to 24.0. Reported version is 7.0. Skipping upgrade.
Schema version reported after upgrade: 7.0

    Previously, the error was not reported by the testing framework because it was also ignored by kea-admin. Now, it is consistent with the MySQL behavior in kea-admin and it no longer ignores upgrade errors. You can see the same upgrade done to a prior version done in the equivalent test mysql_unused_subnet_id_test.

  • a1655b2f add ChangeLog entry

Edited by Andrei Pavel

Merge request reports