Skip to content

Resolve "Rebalance debug logging"

Andrei Pavel requested to merge 1945-rebalance-debug-logging into master

Closes #1945 (closed).

  • 44150638 minor: add +x permission to reorder_message_file.py

  • a74e38ec take premium exhonerated duplicate messages into account

    This makes it easier to run ./tools/check-messages.py to correctly assess the state of messages while developing Kea without having to remove the premium directory.

  • f2789e51 log EVAL_RESULT messages only at debug level

    • Split the 15 occurrences of EVAL_RESULT into one message for each log call in code.
    • Log all these messages only on debug level 50.
    • Remove bad practice catch (...) and the message logged on that if-branch.

  • 9d2826f5 fix check-messages.py on looking at test files

  • ce2f0045 minor fix in ARM: removed extraneous backquotes

  • 397eafcb add missing messages and premium messages to the ARM

    Apart from premium, messages from these files were missing:

    • perfmon_messages.mes
    • pgsql_cb_messages.mes
    • run_script_messages.mes
    • fuzz_messages.mes

  • d5987af2 add ARM section for debug messages indexed by log level

  • e9c271f9 add missing definition for level 70: DBGLVL_TRACE_ALL

    This way, all debug levels used are in src/lib/log/log_dbglevels.*

    And no algebra is used in determining a log level as was the case in:

    const int DBG_ALL = DBGLVL_TRACE_DETAIL + 20;

  • d9c6e0e6 fix debuglevel exception being shadowed by another exception

    "stringValue() called on non-string Element" was being shown instead of "Unsupported debuglevel value 100, expected 0-99".

  • b05951f3 generate kea-messages.rst a priori

    This allows us to document premium messages in the public ARM without having to hand out a copy of the premium sources to readthedocs.

  • c0859047 default to determining list of files automatically in api2doc.py and mes2doc.py

  • 548cbf5a add ChangeLog entry

See how the docs would look here: https://kea.readthedocs.io/en/1945-rebalance-debug-logging/kea-messages.html

#huge-sorry because the file that is thousands of lines of code is auto-generated. There is no expectation to manually keep it maintained, so it's fine.

Edited by Andrei Pavel

Merge request reports