Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
stork
stork
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 138
    • Issues 138
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 3
    • Merge Requests 3
  • Operations
    • Operations
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
  • ISC Open Source Projects
  • storkstork
  • Merge Requests
  • !97

Merged
Opened Mar 16, 2020 by Tomek Mrugalski@tomek🛰Owner10 of 10 tasks completed10/10 tasks

Resolve "(fix and) start running webui unit-tests"

  • Overview 20
  • Commits 52
  • Changes 40

Closes #164 (closed)

The remaining failing tests are:

  • AppDaemonsStatusComponent: TypeError: Cannot read property 'details' of undefined
  • AppComponent: Expected undefined to equal 'Stork'.
  • AppsPageComponent: TypeError: this.handler.handle is not a function
  • Bind9AppTabComponent: TypeError: Cannot read property 'subscribe' of undefined
  • BreadcrumbsComponent: TypeError: this.items is not iterable
  • HaStatusPanelComponent: TypeError: Cannot read property 'state' of undefined
  • HaStatusComponent: Error: Required parameter id was null or undefined when calling getAppServicesStatus.
  • KeaAppTabComponent: TypeError: Cannot read property 'subscribe' of undefined
  • LogViewPageComponent: TypeError: Cannot read property 'subscribe' of undefined
  • PasswordChangePageComponent: Uncaught TypeError: params.get is not a function thrown

This MR also adds dev guide section and new unit tests for menu items visibility.

Edited Oct 27, 2020 by Tomek Mrugalski
Assignee
Assign to
Reviewer
Request review from
0.13
Milestone
0.13 (Past due)
Assign milestone
Time tracking
Reference: isc-projects/stork!97
Source branch: 164-fix-webui-unit-tests