Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • stork stork
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 277
    • Issues 277
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 25
    • Merge requests 25
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • storkstork
  • Merge requests
  • !97

Resolve "(fix and) start running webui unit-tests"

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Tomek Mrugalski requested to merge 164-fix-webui-unit-tests into master Mar 16, 2020
  • Overview 20
  • Commits 52
  • Pipelines 0
  • Changes 40

Closes #164 (closed)

The remaining failing tests are:

  • AppDaemonsStatusComponent: TypeError: Cannot read property 'details' of undefined
  • AppComponent: Expected undefined to equal 'Stork'.
  • AppsPageComponent: TypeError: this.handler.handle is not a function
  • Bind9AppTabComponent: TypeError: Cannot read property 'subscribe' of undefined
  • BreadcrumbsComponent: TypeError: this.items is not iterable
  • HaStatusPanelComponent: TypeError: Cannot read property 'state' of undefined
  • HaStatusComponent: Error: Required parameter id was null or undefined when calling getAppServicesStatus.
  • KeaAppTabComponent: TypeError: Cannot read property 'subscribe' of undefined
  • LogViewPageComponent: TypeError: Cannot read property 'subscribe' of undefined
  • PasswordChangePageComponent: Uncaught TypeError: params.get is not a function thrown

This MR also adds dev guide section and new unit tests for menu items visibility.

Edited Oct 27, 2020 by Tomek Mrugalski
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 164-fix-webui-unit-tests